From: Jonas Dreßler <verdre@v0yd.nl>
Date: Tue, 12 May 2020 10:28:03 +0000 (+0200)
Subject: windowManager: Warn when removing old animationInfo
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~256
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=c23ad83c593880c09efcc733cf1ff6dd9453d187;p=gnome-shell.git

windowManager: Warn when removing old animationInfo

Now that we properly notify mutter about when a size-change animation
has ended, it should never happen that a new size-change animation is
started without the last one being cancelled (ie. 'kill-window-effects'
being emitted).

This means there should also never be an old animationInfo attached to a
window actor, so warn in case we still find one when starting the
animation.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1251
---

diff --git a/js/ui/windowManager.js b/js/ui/windowManager.js
index 97601eee4..1ea5daff7 100644
--- a/js/ui/windowManager.js
+++ b/js/ui/windowManager.js
@@ -1301,8 +1301,10 @@ var WindowManager = class {
 
         actor.freeze();
 
-        if (this._clearAnimationInfo(actor))
+        if (this._clearAnimationInfo(actor)) {
+            log('Old animationInfo removed from actor %s'.format(actor));
             this._shellwm.completed_size_change(actor);
+        }
 
         let destroyId = actor.connect('destroy', () => {
             this._clearAnimationInfo(actor);